Skip to content

Rollup of 3 pull requests #149478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 30, 2025
Merged

Rollup of 3 pull requests #149478

merged 6 commits into from
Nov 30, 2025

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Nov 30, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fee1-dead and others added 6 commits November 29, 2025 20:00
@fee1-dead
collapse constness query match logic
cf91330 
We already have the HIR node data, so no need for asking `def_kind` again.
@tisonkun
Clarify edge cases for Barrier::new
5d8f2b8
@RalfJung
float::min/max: reference NaN bit pattern rules
3287178
@matthiaskrgr
Rollup merge of rust-lang#149236 - tisonkun:patch-1, r=tgross35
bc83bf2 
Clarify edge cases for Barrier::new

... since n-1 is undefined when the usize n is 0.
@matthiaskrgr
Rollup merge of rust-lang#149444 - fee1-dead-contrib:push-lurmmylquws…
9507d5c 
…q, r=oli-obk

collapse `constness` query `match` logic

We already have the HIR node data, so no need for asking `def_kind` again.

r? oli-obk
@matthiaskrgr
Rollup merge of rust-lang#149475 - RalfJung:min-max-nan, r=tgross35
1a9f527 
float::min/max: reference NaN bit pattern rules

Also, the "in particular" transition to the signed zero handling was odd, so I rearranged things a bit: first a self-contained description of the semantics, then an explanation of which operations in other standards/libraries this most closely corresponds to.

r? `@tgross35`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 30, 2025
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Nov 30, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

📌 Commit 1a9f527 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

⌛ Testing commit 1a9f527 with merge f40a70d...

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f40a70d to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2025
@bors bors merged commit f40a70d into rust-lang:main Nov 30, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 30, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 30, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149236 Clarify edge cases for Barrier::new d6e1424216234465bcab20f33d95451452fd4fa3 (link)
#149444 collapse constness query match logic e9dfcc260ba42181daadecf93b25153863270c14 (link)
#149475 float::min/max: reference NaN bit pattern rules a91e32282473e24a0b7fbb35f50772b5d6cbc212 (link)

previous master: 03ce87dfb2

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 03ce87d (parent) -> f40a70d (this PR)

Test differences

Show 503 test diffs

503 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f40a70d2bcd830a4f1f8c7ca1a7f93f1d9d703d6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-21-2: 4880.9s -> 5602.7s (+14.8%)
  2. dist-apple-various: 3444.5s -> 3872.9s (+12.4%)
  3. x86_64-msvc-ext2: 5423.5s -> 5987.5s (+10.4%)
  4. x86_64-gnu-llvm-21-3: 6193.4s -> 5566.6s (-10.1%)
  5. aarch64-gnu-llvm-20-1: 3327.5s -> 3602.3s (+8.3%)
  6. tidy: 156.7s -> 169.3s (+8.0%)
  7. x86_64-gnu-aux: 6275.4s -> 6778.5s (+8.0%)
  8. x86_64-gnu-stable: 6852.0s -> 6318.8s (-7.8%)
  9. x86_64-mingw-1: 9787.8s -> 10519.5s (+7.5%)
  10. dist-ohos-armv7: 4113.5s -> 3806.0s (-7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Nov 30, 2025
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 30, 2025

Finished benchmarking commit (f40a70d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.589s -> 469.915s (-0.98%)
Artifact size: 386.97 MiB -> 386.98 MiB (0.00%)

@bors bors mentioned this pull request Nov 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@matthiaskrgr @bors @rust-timer @rustbot @fee1-dead @tisonkun @RalfJung